Add case to capture enum subtype reduction (addresses #35867)#68
Merged
acutmore merged 3 commits intobloomberg:oss-hackathon-35867from Jun 16, 2022
Merged
Conversation
Signed-off-by: Lawrence Craft <lcraft6@bloomberg.net>
d3076fa to
c710b96
Compare
9945901 to
5126ba9
Compare
Signed-off-by: Lawrence Craft <lcraft6@bloomberg.net>
acutmore
approved these changes
Jun 16, 2022
acutmore
left a comment
There was a problem hiding this comment.
LGTM! Very decent test coverage. Thanks @lawrencecraft
|
We'll now wait for @lawrencecraft to be adding as a maintainer so he can raise the PR himself for full attribution 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: microsoft#35867
Describe your changes
I've added tests to prevent regressions for this bug. I created a few scenarios that could trigger this.
Testing performed
n/a - tests are the only change